Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rancher integration #2471

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

schmidax
Copy link

Revision of the Helm-Charts for use in the Rancher dashboard as an app.
grafik
grafik
grafik
grafik

@FxKu
Copy link
Member

FxKu commented Jan 4, 2024

image

Wat?! We need a lot more explanation here than just screenshots if you want us to review this PR. Why does rancher integration touch 246 files? What are things that are currently missing? No need to write a whole essay but I expect to see a short summary of what you've changed. The diff is just too big and scary. But still, thanks for your contribution :)

@schmidax
Copy link
Author

schmidax commented Jan 4, 2024

The 246 changes actually only have a small background. Your procedure with the chart versions was to save the old versions as tar files. In order to be able to install the older versions of helm (and Rancher in particular), a separate folder must exist for each version containing the templates for the appropriate version.

For Rancher directly, only one extra file per chart is required. The questions.yaml, which prepares the variables from the values.yaml for Rancher in a readable format. I have not yet built the README for Rancher.

I have only done the Rancher preparation for version 1.10.0 and 1.10.1. I unpacked the tar-files into the version folders for all versions. But this is just a suggestion from me. You can only do this for 1.10.0 and higher...

@FxKu FxKu added this to the 2.0 milestone Jan 22, 2024
@schmidax
Copy link
Author

Hi there,

I have now understood how to deal with helm charts. This index.yaml was not quite clear to me. Now I have added the integration into the existing construct (with version 1.11.0) Sorry for this confusion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants