Avoid redundant tail slash check in TrinoRestCatalog #22023
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
takezoe
force-pushed
the
avoid-redundant-pathsuffix-check-in-iceberg-rest-catalog
branch
from
95fdf4f
to
aa52da7
Compare
takezoe
changed the title
takezoe
commented
May 19, 2024
| @@ -349,9 +349,6 @@ public String defaultTableLocation(ConnectorSession session, SchemaTableName sch | |||
| String databaseLocation = (String) properties.get(IcebergSchemaProperties.LOCATION_PROPERTY); | |||
| checkArgument(databaseLocation != null, "location must be set for %s", schemaTableName.getSchemaName()); | |||
|
|
|||
| if (databaseLocation.endsWith("/")) { | |||
| return databaseLocation + tableName; | |||
| } | |||
There was a problem hiding this comment.
This seems to be checked inside appendPath().
takezoe
force-pushed
the
avoid-redundant-pathsuffix-check-in-iceberg-rest-catalog
branch
from
aa52da7
to
b2b1aea
Compare
takezoe
force-pushed
the
avoid-redundant-pathsuffix-check-in-iceberg-rest-catalog
branch
from
b2b1aea
to
a0acb32
Compare
ebyhr
approved these changes
May 19, 2024
takezoe
deleted the
avoid-redundant-pathsuffix-check-in-iceberg-rest-catalog
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Avoid redundant path suffix check in
TrinoRestCatalogAdditional context and related issues
Release notes
(x) This is not user-visible or is docs only, and no release notes are required.
( ) Release notes are required. Please propose a release note for me.
( ) Release notes are required, with the following suggested text: