Trino-LanceDB plugin #21880
Trino-LanceDB plugin #21880
Conversation
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
plugin/trino-lancedb/pom.xml
Outdated
| </dependency> | ||
| </dependencies> | ||
|
|
||
| <repositories> |
plugin/trino-lancedb/pom.xml
Outdated
| <dependency> | ||
| <groupId>com.lancedb</groupId> | ||
| <artifactId>lance-core</artifactId> | ||
| <version>0.1-SNAPSHOT</version> |
There was a problem hiding this comment.
For the merge this will have to be an actual release available in Maven Central .. I can help with getting that going if needed
There was a problem hiding this comment.
Looks like you can switch to 0.0.1 now .. also introduce a property dep.lancedb.version and use it in both dependencies
There was a problem hiding this comment.
yeah i released it with just the osx binary. i think we need the ubuntu release version at least to get CI to green. will prep another one but should be quick
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
2 similar comments
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
walterddr
force-pushed
the
trino_lance_plugin_init
branch
from
87609b6
to
b452606
Compare
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
|
We should add documentation and the logo as well and maybe take this out of draft mode for first feedback and testing. |
yes. will do once we get a green CI, (also with documentation + logo) |
|
Thank you for your pull request and welcome to the Trino community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. Continue to work with us on the review and improvements in this PR, and submit the signed CLA to cla@trino.io. Photos, scans, or digitally-signed PDF files are all suitable. Processing may take a few days. The CLA needs to be on file before we merge your changes. For more information, see https://github.com/trinodb/cla |
upgraded to a test release version. PTAL @mosabua. i think lance is still working on a x-platform release so we might still bump the version later. but this should work for linux x86 platform |
|
CLA processing is a bit behind .. no worries. We can still proceed with reviewing and such |
walterddr
force-pushed
the
trino_lance_plugin_init
branch
2 times, most recently
from
eb8ff88
to
c5d4095
Compare
- rename with .lance suffix for test, and use lancedb-core for metadata access - fix pom.xml issue
walterddr
force-pushed
the
trino_lance_plugin_init
branch
from
c5d4095
to
92db050
Compare
Description
Initial version of Trino-LanceDB plugin