Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

INSERT RELATION #4057

Merged
merged 17 commits into from
May 28, 2024
Merged

INSERT RELATION #4057

merged 17 commits into from
May 28, 2024

Conversation

kearfy
Copy link
Member

@kearfy kearfy commented May 17, 2024

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

Ability to do batch creation of relations

What does this change do?

It adds a RELATION keyword to the INSERT-statement, allowing you to batch create relations.

Additionally, this PR also make the INTO keyword on INSERT statements optional, to allow batch inserting relations on arbitrary tables

What is your testing strategy?

Added tests

Is this related to any issues?

Fixes #3247

Does this change need documentation?

If this pull request requires changes, updates, or improvements to the documentation, then add a corresponding issue on the docs.surrealdb.com repository, and link to it here.

Have you read the Contributing Guidelines?

@kearfy kearfy requested review from tobiemh and a team as code owners May 17, 2024 13:26
core/src/sql/statements/insert.rs Outdated Show resolved Hide resolved
core/src/sql/statements/insert.rs Outdated Show resolved Hide resolved
@tobiemh tobiemh mentioned this pull request May 28, 2024
3 tasks
phughk
phughk previously approved these changes May 28, 2024
Copy link
Contributor

@phughk phughk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, left a comment but up to you. I think r#in conventions should be left to tools that can't choose names easily :P

core/src/sql/statements/insert.rs Outdated Show resolved Hide resolved
phughk
phughk previously approved these changes May 28, 2024
tobiemh
tobiemh previously approved these changes May 28, 2024
@kearfy kearfy enabled auto-merge May 28, 2024 10:50
@kearfy kearfy added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch May 28, 2024
@kearfy kearfy dismissed stale reviews from tobiemh and phughk via d8a1515 May 28, 2024 11:22
@kearfy kearfy added this pull request to the merge queue May 28, 2024
Merged via the queue into main with commit 5df3d2d May 28, 2024
23 checks passed
@kearfy kearfy deleted the micha/insert-relation branch May 28, 2024 12:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bug: Edge inserted via INSERT cannot be queried with ->
3 participants