Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes parse error for variables after fetch #4055

Closed

Conversation

Vignesh1-art
Copy link

Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.

What is the motivation?

Parsing fails if variables are encountered after FETCH statement

What does this change do?

Fixes this problem. I have added new parsing function to parse list of variables and Parses it after FETCH statement

What is your testing strategy?

Did some manual testing testing, Ran through unit making sure does not break existing things.

Is this related to any issues?

#3028

Does this change need documentation?

If this pull request requires changes, updates, or improvements to the documentation, then add a corresponding issue on the docs.surrealdb.com repository, and link to it here.

  • No documentation needed

Have you read the Contributing Guidelines?

@Vignesh1-art Vignesh1-art requested review from tobiemh and a team as code owners May 17, 2024 12:25
@Vignesh1-art
Copy link
Author

@tobiemh or @DelSkayn someone Please review and approve the workflow

@tobiemh
Copy link
Member

tobiemh commented May 20, 2024

Hi @Vignesh1-art thanks for this pull request 🎉 ! Parameters within the FETCH clause were not previously supported, so we'll need to add new tests for this behaviour, before we can approve this PR, to ensure that the behaviour works as expected.

It's probably best to add a test in to lib/tests/fetch.rs 😃 .

@Vignesh1-art Vignesh1-art deleted the fix-variables-after-fetch branch May 29, 2024 02:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants