Bind to loopback address by default #4054
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiemh
approved these changes
May 20, 2024
mumoshu
approved these changes
May 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for submitting this pull request! We really appreciate you spending the time to work on these changes.
What is the motivation?
To prevent SurrealDB users from accidentally exposing the service to an untrusted network. This is specially relevant for users running SurrealDB in cloud instances with publicly addressable network interfaces.
What does this change do?
Changes the default value for the
--bindflag of thestartsubcommand from0.0.0.0:8000to127.0.0.1:8000.What is your testing strategy?
Ensure that existing tests work.
Is this related to any issues?
Does this change need documentation?
Yes, this needs an update on the CLI documentation page.
--bindflag in 2.0 docs.surrealdb.com#548Have you read the Contributing Guidelines?