Make JpaSort.unsafe() operational for HQL, EQL, and JPQL. #3187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gregturn
force-pushed
the
issue/gh-3172
branch
from
aa6b908
to
2e8805e
Compare
|
Considering it's a bug fix and all the new code is package-private (or private), then all the HQL and JPQL parts should be a candidate for backporting, at least to all versions that have query parsing. However, to do so would ALSO require backporting the |
We have offered this method as a way for people to customize an ORDER BY clause beyond a simple property name. For example, someone could use "LENGTH(firstname)" as a function to order by the length of each row's lastname instead of ordering by the lastname itself. By using the relevant parser and applying a different visitor, this commit make operational a feature that shows little evidence of ever having worked. See #3172.
gregturn
force-pushed
the
issue/gh-3172
branch
from
2e8805e
to
6aad414
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To support testing various configurations, I also implemente
@HideHibernate,@HideEclipseLink, and@HidePersistenceProvidersso that test methods and test classes can verify these classpath checks.