Updated RootContext #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huangzhhui
reviewed
Aug 26, 2022
| public static function bindBranchType(int $branchType) | ||
| { | ||
| if (empty($branchType)) { |
There was a problem hiding this comment.
int 类型约束了这里不会有 null 的吧？
There was a problem hiding this comment.
这里其实只是为了防止 0 传进来，所以我加了
huangzhhui
reviewed
Aug 26, 2022
| /** | ||
| * entry map | ||
| */ | ||
| public static function entries(): array |
There was a problem hiding this comment.
这个是 array 还是 ContainerInterface ?
huangzhhui
reviewed
Aug 26, 2022
src/Core/Context/RootContext.php
Outdated
| @@ -118,12 +135,22 @@ public static function getBranchType(): ?int | |||
| return $branchType; | |||
| } | |||
|
|
|||
| /** | |||
| * bind branch type | |||
huangzhhui
reviewed
Aug 26, 2022
| @@ -68,11 +68,15 @@ public static function bind(string $xid): void | |||
| { | |||
| if (! $xid) { | |||
| static::log('debug', 'xid is blank, switch to unbind operation!'); | |||
| self::unbind(); | |||
There was a problem hiding this comment.
这里 unbind 之后后面的逻辑还需要走吗？
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#11