Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(func): impl quote_literal & quote_nullable #16807

Merged
merged 3 commits into from
May 23, 2024
Merged

Conversation

fuyufjh
Copy link
Contributor

@fuyufjh fuyufjh commented May 17, 2024

I hereby agree to the terms of the RisingWave Labs, Inc. Contributor License Agreement.

What's changed and what's your intention?

Closes #16792

References:

Checklist

  • I have written necessary rustdoc comments
  • I have added necessary unit tests and integration tests
  • I have added test labels as necessary. See details.
  • I have added fuzzing tests or opened an issue to track them. (Optional, recommended for new SQL features Sqlsmith: Sql feature generation #7934).
  • My PR contains breaking changes. (If it deprecates some features, please create a tracking issue to remove them in the future).
  • All checks passed in ./risedev check (or alias, ./risedev c)
  • My PR changes performance-critical code. (Please run macro/micro-benchmarks and show the results.)
  • My PR contains critical fixes that are necessary to be merged into the latest release. (Please check out the details)

Documentation

  • My PR needs documentation updates. (Please use the Release note section below to summarize the impact on users)

Release note

If this PR includes changes that directly affect users or other significant modifications relevant to the community, kindly draft a release note to provide a concise summary of these changes. Please prioritize highlighting the impact these changes will have on users.

Copy link
Contributor

@wangrunji0408 wangrunji0408 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@neverchanje neverchanje added the user-facing-changes Contains changes that are visible to users label May 17, 2024
@fuyufjh fuyufjh requested a review from xiangjinwu May 20, 2024 10:05
src/frontend/src/binder/expr/function.rs Outdated Show resolved Hide resolved
@fuyufjh fuyufjh enabled auto-merge May 21, 2024 08:11
@fuyufjh fuyufjh added this pull request to the merge queue May 23, 2024
Merged via the queue into main with commit 657a1d5 May 23, 2024
30 of 31 checks passed
@fuyufjh fuyufjh deleted the eric/quote_literal branch May 23, 2024 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/feature user-facing-changes Contains changes that are visible to users
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement quote_literal
4 participants