Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: fix some typos in code comments #53371

Merged
merged 1 commit into from
May 20, 2024
Merged

Conversation

lilin90
Copy link
Member

@lilin90 lilin90 commented May 18, 2024

What problem does this PR solve?

Issue Number: N/A

Problem Summary: Fix some typos in code comments for 43 files.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code is changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 18, 2024
Copy link

codecov bot commented May 18, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 74.6317%. Comparing base (9581442) to head (4d98017).
Report is 8 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #53371        +/-   ##
================================================
+ Coverage   72.5153%   74.6317%   +2.1163%     
================================================
  Files          1505       1505                
  Lines        429836     430707       +871     
================================================
+ Hits         311697     321444      +9747     
+ Misses        98832      89376      -9456     
- Partials      19307      19887       +580     
Flag Coverage Δ
integration 49.1518% <50.0000%> (?)
unit 71.3793% <78.5714%> (-0.0306%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9957% <ø> (ø)
parser ∅ <ø> (∅)
br 50.4640% <ø> (+9.0803%) ⬆️

Copy link

ti-chi-bot bot commented May 20, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-05-19 05:46:35.453578716 +0000 UTC m=+1977749.210714289: ☑️ agreed by ngaut.
  • 2024-05-20 02:04:15.664337393 +0000 UTC m=+2050809.421472966: ☑️ agreed by lance6716.

@lance6716
Copy link
Contributor

/assign @windtalker @yudongusa

Copy link

ti-chi-bot bot commented May 20, 2024

@lance6716: GitHub didn't allow me to assign the following users: yudongusa.

Note that only pingcap members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @windtalker @yudongusa

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Contributor

@windtalker windtalker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonn7
Copy link

easonn7 commented May 20, 2024

/approve

Copy link

ti-chi-bot bot commented May 20, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: easonn7, lance6716, ngaut, windtalker

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label May 20, 2024
@ti-chi-bot ti-chi-bot bot merged commit 68219b9 into pingcap:master May 20, 2024
23 checks passed
@lilin90 lilin90 deleted the fix-typos branch May 20, 2024 08:12
terry1purcell pushed a commit to terry1purcell/tidb that referenced this pull request May 20, 2024
RidRisR pushed a commit to RidRisR/tidb that referenced this pull request May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved lgtm release-note-none size/L Denotes a PR that changes 100-499 lines, ignoring generated files. skip-issue-check
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants