Backport of improvements #1973
Open
Backport of improvements #1973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
iliaal
commented
May 31, 2021
iliaal
commented
- Introduced size limit for compression
- Introduced min compression ratio
- Allow by-pass of igbinary for string literals
- Allow clone of redis object
…edis_clone_develop
Presently PhpRedis will segfault if users attempt to clone either the Redis or RedisCluster objects. We plan on investigating proper clone support in future releases, but for now just diable the handlers.
Without this, performing a HMGET call fails to decompress the data before returning it to php.
ZSTD uses two defined error numbers to inform the caller when the compressed data is invalid (e.g. wrong magic number) or the size is unknown. We should always know the size so abort if ZSTD returns either to us. Fixes: phpredis#1936
Rework the session locking unit tests to be less reliant on arbitrary sleep calls which can be very troublesome when running in Travis and especially when running in Travis under valgrind.
…elop_simple_strings
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.