Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Makedeb for php7x #1226

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

Conversation

masterjus
Copy link

Currently I had few problems:

  • phpredis from apt repository doesn't installs for php-fpm
  • existing ansible roles to install phpredis doesn't work because of very old mkdeb.sh

Current changes makes possible to make .deb package which will install phpredis for php-cli and php-fpm

It autodetects currently installed php version and makes package for it.

It automatically sets phpredis version (must be started from number, so "develop" will not work) from php_redis.h file.

@yatsukhnenko
Copy link
Member

Hey @masterjus, thank you for your pull request.
Unfortunately I don't want to accept this PR because I think that people should use deb and rpm packages from official repos for their distros.
@michael-grunder what do you think?

@masterjus
Copy link
Author

masterjus commented Aug 21, 2017

@yatsukhnenko
it doesn't exists for php7.x-fpm.
This why I've started this activity.

I want to install this package by ansible but the only way is to compile it from source. But this is bad solution.

@michael-grunder
Copy link
Member

@yatsukhnenko People are still free to use official packages. Doesn't seem to hurt anything to have a script in the repo.

@yatsukhnenko
Copy link
Member

@michael-grunder I don't know anything about deb packages so I can't check changes in this PR. Could you review it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants