Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(echo): Use dist for Echo artifacts #5590

Merged
merged 15 commits into from
May 20, 2024
Merged

Conversation

rifont
Copy link
Contributor

@rifont rifont commented May 16, 2024

What changed? Why was the change needed?

  • The Echo SDK was published without pointing to the built artifacts, resulting in the error belo when attempting to use the SDK. This PR fixes the package.json to point to the built artifacts.
  • Update readme to reflect actual SDK API
  • Delete the sdk package pnpm-lock.yml, as the root pnpm-lock.yml should be used instead
  • Fix pnpm v9 migration issues

Screenshots

Error when using latest @novu/sdk

> next dev --port=4000

   ▲ Next.js 14.1.0
   - Local:        http://localhost:4000
   - Environments: .env.local

 ✓ Ready in 2.8s
 ○ Compiling / ...
 ✓ Compiled / in 6.6s (5781 modules)
 ○ Compiling /api/echo ...
 ⨯ ./app/api/echo/route.ts:1:0
Module not found: Can't resolve '@novu/echo/next'
> 1 | import { serve } from "@novu/echo/next";
  2 | import { echo } from "../../echo/client";
  3 |
  4 | export const { GET, POST, PUT } = serve({ client: echo });

https://nextjs.org/docs/messages/module-not-found
 ⨯ ./app/api/echo/route.ts:1:0
Module not found: Can't resolve '@novu/echo/next'
> 1 | import { serve } from "@novu/echo/next";
  2 | import { echo } from "../../echo/client";
  3 |
  4 | export const { GET, POST, PUT } = serve({ client: echo });

https://nextjs.org/docs/messages/module-not-found
 ⨯ ./app/api/echo/route.ts:1:0
Module not found: Can't resolve '@novu/echo/next'
> 1 | import { serve } from "@novu/echo/next";
  2 | import { echo } from "../../echo/client";
  3 |
  4 | export const { GET, POST, PUT } = serve({ client: echo });

https://nextjs.org/docs/messages/module-not-found
<w> [webpack.cache.PackFileCacheStrategy] Caching failed for pack: Error: ENOENT: no such file or directory, rename '/Users/rifont/git/lightonia-app/.next/cache/webpack/client-development-fallback/0.pack.gz_' -> '/Users/rifont/git/lightonia-app/.next/cache/webpack/client-development-fallback/0.pack.gz'
<w> [webpack.cache.PackFileCacheStrategy] Caching failed for pack: Error: ENOENT: no such file or directory, rename '/Users/rifont/git/lightonia-app/.next/cache/webpack/client-development-fallback/0.pack.gz_' -> '/Users/rifont/git/lightonia-app/.next/cache/webpack/client-development-fallback/0.pack.gz'
 ✓ Compiled /_error in 948ms (3006 modules)
^C
Expand for optional sections

Related enterprise PR

Special notes for your reviewer

Copy link

netlify bot commented May 16, 2024

Deploy Preview for novu-design ready!

Name Link
🔨 Latest commit 29257aa
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/664b50dcdde50a000897d4a5
😎 Deploy Preview https://deploy-preview-5590--novu-design.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented May 16, 2024

Deploy Preview for dev-web-novu ready!

Name Link
🔨 Latest commit 29257aa
🔍 Latest deploy log https://app.netlify.com/sites/dev-web-novu/deploys/664b50dc99c6d500083c8a6c
😎 Deploy Preview https://deploy-preview-5590--dev-web-novu.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@rifont rifont requested a review from LetItRock May 16, 2024 21:45
@rifont
Copy link
Contributor Author

rifont commented May 19, 2024

This PR is pending merging of #5598 to resolve pnpm lockfile consistency issues, by upgrading to lockfile v9.

@rifont rifont changed the title fix(sdk): Use dist for sdk artifacts fix(echo): Use dist for Echo artifacts May 20, 2024
@SokratisVidros SokratisVidros merged commit e99beb3 into next May 20, 2024
28 checks passed
@SokratisVidros SokratisVidros deleted the hotfix-echo-sdk-artifacts branch May 20, 2024 13:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants