-
Notifications
You must be signed in to change notification settings - Fork 3.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sms/unifonic #5576
Sms/unifonic #5576
Conversation
…into sms/unifonic
…into sms/unifonic
…into sms/unifonic
👷 Deploy request for dev-web-novu pending review.Visit the deploys page to approve it
|
❌ Deploy Preview for novu-design failed. Why did it fail? →
|
@novuhq/novu-web I will handle this addition here 🙏 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@muhammadfazeel Thank you for your contribution :) ,
A change will need to be made because providers structure has been recently changed, currently providers are under packages/ providers, please use the updated version of next and run providers:generate, it's a significantly simplified version,, all the other work you have done is perfectly fine, the folder providers/* does not exist any more so the two files:
providers/unifonic/src/lib/unifonic.provider.spec.ts
providers/unifonic/src/lib/unifonic.provider.ts
will have to move into packages/providers/src/lib/unifonic
don't forget to make sure it is exposed as an export in the index.ts within packages/providers/src/lib/
Best Regards,
Gal
Team Novu
Closing in favor in another PR we are working with @muhammadfazeel on 🙏 |
What changed? Why was the change needed?
Added a new sms providor unifonic
Screenshots
Expand for optional sections
Related enterprise PR
For NEOM poc
Special notes for your reviewer