Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sms/unifonic #5576

Closed
wants to merge 8 commits into from
Closed

Conversation

muhammadfazeel1
Copy link

What changed? Why was the change needed?

Added a new sms providor unifonic

Screenshots

image

Expand for optional sections

Related enterprise PR

For NEOM poc

Special notes for your reviewer

@muhammadfazeel1 muhammadfazeel1 requested a review from a team as a code owner May 15, 2024 15:48
Copy link

netlify bot commented May 15, 2024

👷 Deploy request for dev-web-novu pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 060e332

Copy link

netlify bot commented May 15, 2024

Deploy Preview for novu-design failed. Why did it fail? →

Name Link
🔨 Latest commit 060e332
🔍 Latest deploy log https://app.netlify.com/sites/novu-design/deploys/6644d955a502ab00082a7079

@scopsy scopsy requested review from scopsy and removed request for a team May 15, 2024 17:44
@scopsy
Copy link
Contributor

scopsy commented May 15, 2024

@novuhq/novu-web I will handle this addition here 🙏

Copy link
Contributor

@tatarco tatarco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@muhammadfazeel Thank you for your contribution :) ,
A change will need to be made because providers structure has been recently changed, currently providers are under packages/ providers, please use the updated version of next and run providers:generate, it's a significantly simplified version,, all the other work you have done is perfectly fine, the folder providers/* does not exist any more so the two files:
providers/unifonic/src/lib/unifonic.provider.spec.ts
providers/unifonic/src/lib/unifonic.provider.ts
will have to move into packages/providers/src/lib/unifonic
don't forget to make sure it is exposed as an export in the index.ts within packages/providers/src/lib/

Best Regards,
Gal
Team Novu

@scopsy
Copy link
Contributor

scopsy commented May 20, 2024

Closing in favor in another PR we are working with @muhammadfazeel on 🙏

@scopsy scopsy closed this May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants