Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-16069 Allow the indexes to start with embedded setup #12377

Merged
merged 2 commits into from
May 23, 2024

Conversation

fax4ever
Copy link
Contributor

@github-actions github-actions bot added this to the 15.0.4.Final milestone May 15, 2024
@fax4ever fax4ever added 15.0.x Annotate a PR with this label if you want it to be backported to the 15.0.x branch and removed Needs Rebase labels May 21, 2024
@fax4ever
Copy link
Contributor Author

Rebased!

Copy link
Member

@pruivo pruivo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just some suggestions 👍

@@ -81,6 +81,20 @@ Set the `indexing-mode` to `manual`:
include::xml/indexing_manual.xml[]
----

[discrete]
== Use (force)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use force?

[discrete]
== Use (force)

If the cache is Protobuf-encoded and the indexes initialized from a {brandname} server instance,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nitpicking, I would use protostream instead of protobuf just to match the media type name.

@fax4ever
Copy link
Contributor Author

LGTM, just some suggestions 👍

Thank you Pedro for the review.
I applied all the ideas

@pruivo pruivo removed the 15.0.x Annotate a PR with this label if you want it to be backported to the 15.0.x branch label May 23, 2024
@pruivo pruivo merged commit b5b7516 into infinispan:main May 23, 2024
8 of 9 checks passed
@pruivo
Copy link
Member

pruivo commented May 23, 2024

merged! thanks @fax4ever !

@fax4ever
Copy link
Contributor Author

Thanks Pedro!

@fax4ever fax4ever deleted the ISPN-16069 branch May 23, 2024 13:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants