Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISPN-16057 Restore 3rd party integration tests for Wildfly and Tomcat #12365

Merged
merged 1 commit into from
May 19, 2024

Conversation

ryanemerson
Copy link
Contributor

https://issues.redhat.com/browse/ISPN-16057

Wildfly version bumped to 32.0

Tomcat tested with 10.1.23. Unfortunately we need to rely on a SNAPSHOT release of arquillian-tomcat-managed-10 as this has not yet been released, however I'm chasing our good friend @rhusar to see if we can get this released ASAP. This won't affect upstream CI as we don't execute the Tomcat tests here anyway.

@tristantarrant I dropped MemcachedClientIT as it relies upon the SimpleMemcachedClient that AFAICT is no longer compatible with the changes on our server and I didn't think was worth the time investment of debugging/fixing.

@github-actions github-actions bot added this to the 15.0.4.Final milestone May 10, 2024
@tristantarrant
Copy link
Member

Could not find artifact org.opensaml:opensaml-core:jar:4.2.0 in central (https://repo.maven.apache.org/maven2/)

@tristantarrant
Copy link
Member

According to mvnrepository.com, it seems like version 4.2.0 is only available from the Shibboleth repo: https://mvnrepository.com/artifact/org.opensaml/opensaml-core?repo=shibboleth-releases

@rhusar
Copy link
Member

rhusar commented May 10, 2024

@ryanemerson Sure thing! Lets catch up on Monday as I am on PTO today.

@rhusar
Copy link
Member

rhusar commented May 13, 2024

Tomcat tested with 10.1.23. Unfortunately we need to rely on a SNAPSHOT release of arquillian-tomcat-managed-10 as this has not yet been released, however I'm chasing our good friend @rhusar to see if we can get this released ASAP. This won't affect upstream CI as we don't execute the Tomcat tests here anyway.

@ryanemerson Looking at this bit more today, what you could use right-away, is the arquillian-tomcat-managed-8 version 1.1.0.Final which is compatible with Tomcat 10.1 as well, e.g. just use the following in the pom:

        <dependency>
            <groupId>org.jboss.arquillian.container</groupId>
            <artifactId>arquillian-tomcat-managed-8</artifactId>
            <version>1.1.0.Final</version>
            <scope>test</scope>
        </dependency>

Should that be problematic, we can just do the release form the main branch of that project as originally discused.

@ryanemerson
Copy link
Contributor Author

@rhusar I just tried again to be sure and I get 500 errors with arquillian-tomcat-managed-8 and Tomcat 10.1.23, so I think we need the release.

@rhusar
Copy link
Member

rhusar commented May 14, 2024

@rhusar I just tried again to be sure and I get 500 errors with arquillian-tomcat-managed-8 and Tomcat 10.1.23, so I think we need the release.

@ryanemerson OK cool - the release is out now - https://github.com/arquillian/arquillian-container-tomcat/releases/tag/1.2.1.Final and released in our nexus (so it might need a minute to sync). Let me know if that works for you :-)

@ryanemerson
Copy link
Contributor Author

Thanks @rhusar that worked for me locally.

@tristantarrant This should be good to merge once CI has completed.

- Update jboss repository url in maven-settings.xml
- Use maven-settings.xml when executing tests to ensure Wildfly dependencies can be resolved
@tristantarrant tristantarrant merged commit d444538 into infinispan:main May 19, 2024
9 checks passed
@tristantarrant
Copy link
Member

Thanks @ryanemerson

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants