[v15] Refactor registration code into lib/auth/join #41748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rosstimothy
added
backport
no-changelog
rosstimothy
force-pushed
the
tross/backport-41679/v15
branch
3 times, most recently
from
1241881
to
2753c6e
Compare
zmb3
approved these changes
May 18, 2024
strideynet
approved these changes
May 20, 2024
* Refactor joining code into lib/auth/join auth.Register and auth.RegisterParams were moved into the new package to prevent clients(tbot) from depending on lib/auth. For the moment only iam joining has been moved into the new package. All other join methods have been left behind in their lib/auth/join_foo.go file and will be addressed in future PRs if need be. This removes lib/auth entirely from tbot and reduces its binary size by ~10-20MB.
rosstimothy
force-pushed
the
tross/backport-41679/v15
branch
from
2753c6e
to
a245ebe
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #41679 to branch/v15