Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove AD Desktop Discover Flow #41742

Merged
merged 6 commits into from
May 28, 2024
Merged

Remove AD Desktop Discover Flow #41742

merged 6 commits into from
May 28, 2024

Conversation

ibeckermayer
Copy link
Contributor

Removes the AD Desktop Discover Flow and the documentation that pointed to it, marking the relevant endpoints as deprecated. Changes the Active Directory Users discovery tile to point to the manual documentation (https://goteleport.com/docs/desktop-access/active-directory-manual):

image

@github-actions GitHub Actions
Copy link

The PR changelog entry failed validation: Changelog entry not found in the PR body. Please add a "no-changelog" label to the PR, or changelog lines starting with changelog: followed by the changelog entries for the PR.

@ibeckermayer ibeckermayer added the no-changelog Indicates that a PR does not require a changelog entry label May 18, 2024
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-equ2dqxy5-goteleport.vercel.app/docs/ver/preview

@zmb3
Copy link
Collaborator

zmb3 commented May 18, 2024

Isn't there a bunch more web code that can be removed?

@ibeckermayer
Copy link
Contributor Author

Isn't there a bunch more web code that can be removed?

🙈

4ba90ea

@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-hd3pyfbyj-goteleport.vercel.app/docs/ver/preview

kimlisa
kimlisa approved these changes May 20, 2024
View reviewed changes
web/packages/teleport/src/services/userEvent/types.ts
DesktopActiveDirectoryConfigure = 'tp.ui.discover.desktop.activeDirectory.configure',
AutoDiscoveredResources = 'tp.ui.discover.autoDiscoveredResources',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'd put this back, it wasn't made specifically for desktops (though it was the only resource emitting it), but it maybe useful later?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should just bring it back if/when we actually need it (YAGNI). It looks like I missed the DesktopActiveDirectoryConfigure above this, too.

@public-teleport-github-review-bot public-teleport-github-review-bot bot removed the request for review from ravicious May 20, 2024 17:20
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-ari8mnwem-goteleport.vercel.app/docs/ver/preview

@zmb3
Copy link
Collaborator

zmb3 commented May 20, 2024

Removed the backport label for v15. This is a big enough change that it should go in a major.

@ibeckermayer ibeckermayer added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@ibeckermayer ibeckermayer added this pull request to the merge queue May 23, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 23, 2024
@ibeckermayer ibeckermayer added this pull request to the merge queue May 28, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 28, 2024
@github-actions GitHub Actions
Copy link

🤖 Vercel preview here: https://docs-mf34u69um-goteleport.vercel.app/docs/ver/preview

@ibeckermayer ibeckermayer added this pull request to the merge queue May 28, 2024
Merged via the queue into master with commit 1be4b50 May 28, 2024
42 checks passed
@ibeckermayer ibeckermayer deleted the isaiah/remove-ad-install-workflow branch May 28, 2024 21:13
@public-teleport-github-review-bot
Copy link

@ibeckermayer See the table below for backport results.

Branch Result
branch/v16 Create PR

This was referenced May 28, 2024
Merged
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@avatus avatus avatus approved these changes

@kimlisa kimlisa kimlisa approved these changes

Assignees
No one assigned
Labels
backport/branch/v16 desktop-access documentation no-changelog Indicates that a PR does not require a changelog entry size/sm ui
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ibeckermayer @zmb3 @avatus @kimlisa