-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix issue with ignored StatefulSet
labels on Cilium.
#9790
Conversation
Skipping CI for Draft Pull Request. |
@axel7born: The label(s) In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/test all |
0dcbad3
to
545ff26
Compare
/test all |
@axel7born: The following tests failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
@DockToFuture and I have decided to use gardener/gardener-extension-networking-cilium#326 instead of this or https://github.com/ScheererJ/gardener/tree/enhancement/ha-vpn-headless to mitigate the issues introduced by cilium v1.15 with regards to the network policy label handling. Hence, this pull request is no longer required. /close |
@ScheererJ: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
How to categorize this PR?
/area networking
/kind bug
What this PR does / why we need it:
Cilium ignores the
StatefulSet
pod label as relevant for identities. This label can't be used aspodSelector
inNetworkPoliciy
s. This PR adds an additional label to the pods ofvpn-seed-server StateFulset
. The label is used Selector in thevpn-seed-server
services and by the networkpolicy controller aspodSelector
for network policies.https://docs.cilium.io/en/stable/operations/performance/scalability/identity-relevant-labels/
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Release note: