Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with ignored StatefulSet labels on Cilium. #9790

Closed
wants to merge 1 commit into from

Conversation

axel7born
Copy link
Contributor

@axel7born axel7born commented May 17, 2024

How to categorize this PR?

/area networking
/kind bug

What this PR does / why we need it:
Cilium ignores the StatefulSet pod label as relevant for identities. This label can't be used as podSelector in NetworkPoliciys. This PR adds an additional label to the pods of vpn-seed-server StateFulset. The label is used Selector in the vpn-seed-server services and by the networkpolicy controller as podSelector for network policies.

https://docs.cilium.io/en/stable/operations/performance/scalability/identity-relevant-labels/

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixes an issue with ignored `StatefulSet` labels on Cilium.

Copy link
Contributor

gardener-prow bot commented May 17, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/networking Networking related labels May 17, 2024
Copy link
Contributor

gardener-prow bot commented May 17, 2024

@axel7born: The label(s) kind/fix cannot be applied, because the repository doesn't have them.

In response to this:

How to categorize this PR?

/area networking
/kind fix

What this PR does / why we need it:
Cilium ignores the StatefulSet pod label as relevant for identities. This label can't be used as podSelector in NetworkPoliciys. This PR adds an additional label to the pods of vpn-seed-server StateFulset. The label is used Selector in the vpn-seed-server services and by the networkpolicy controller as podSelector for network policies.

https://docs.cilium.io/en/stable/operations/performance/scalability/identity-relevant-labels/

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Fixes an issue with ignored `StatefulSet` labels on Cilium.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Copy link
Contributor

gardener-prow bot commented May 17, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ary1992 for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 17, 2024
@axel7born
Copy link
Contributor Author

/test all

@axel7born
Copy link
Contributor Author

/test all

Copy link
Contributor

gardener-prow bot commented May 17, 2024

@axel7born: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-unit 545ff26 link true /test pull-gardener-unit
pull-gardener-e2e-kind-ha-multi-zone 545ff26 link true /test pull-gardener-e2e-kind-ha-multi-zone

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@ScheererJ
Copy link
Contributor

@DockToFuture and I have decided to use gardener/gardener-extension-networking-cilium#326 instead of this or https://github.com/ScheererJ/gardener/tree/enhancement/ha-vpn-headless to mitigate the issues introduced by cilium v1.15 with regards to the network policy label handling. Hence, this pull request is no longer required.

/close

@gardener-prow gardener-prow bot closed this May 22, 2024
Copy link
Contributor

gardener-prow bot commented May 22, 2024

@ScheererJ: Closed this PR.

In response to this:

@DockToFuture and I have decided to use gardener/gardener-extension-networking-cilium#326 instead of this or https://github.com/ScheererJ/gardener/tree/enhancement/ha-vpn-headless to mitigate the issues introduced by cilium v1.15 with regards to the network policy label handling. Hence, this pull request is no longer required.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/networking Networking related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants