-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add go:embedded files to skaffold dependencies #9778
Conversation
Hi @maboehm. Thanks for your PR. I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
# always add VERSION file | ||
echo "VERSION" >> "$path_actual_dependencies" | ||
# add vendor if the vendor/ dir exists | ||
if [[ -d "$repo_root/vendor" ]]; then | ||
echo "vendor" >> "$path_actual_dependencies" | ||
fi | ||
|
||
# sort dependencies | ||
sort -fo "$path_current_skaffold_dependencies"{,} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: IMO we should not sort the dependencies that we retrieved from the current config, so I removed this
/ok-to-test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Cool. Thank you!
/lgtm
/approve
/retest
LGTM label has been added. Git tree hash: 9b6fc442bbdd6991f7d13c3168975dad6d56f48b
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@maboehm: The following test failed, say
Full PR test history. Your PR dashboard. Command help for this repository. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
/retest |
How to categorize this PR?
/area dev-productivity
/kind enhancement
What this PR does / why we need it:
Adds dependencies introduced by embedded files to
skaffold.yaml
. Unfortunately,go list
does not recursively resolve embeddings, so we have to approximate, by checking every (indirect) local dependency. This includes some false positives, since this does not check if the embedding is actually used, but I think its good enough.Which issue(s) this PR fixes:
Special notes for your reviewer:
Release note: