Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add go:embedded files to skaffold dependencies #9778

Merged
merged 3 commits into from
May 21, 2024

Conversation

maboehm
Copy link
Contributor

@maboehm maboehm commented May 16, 2024

How to categorize this PR?
/area dev-productivity
/kind enhancement

What this PR does / why we need it:
Adds dependencies introduced by embedded files to skaffold.yaml. Unfortunately, go list does not recursively resolve embeddings, so we have to approximate, by checking every (indirect) local dependency. This includes some false positives, since this does not check if the embedding is actually used, but I think its good enough.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Release note:

`Skaffold` now rebuilds components if embedded files have changed.

@gardener-prow gardener-prow bot added area/dev-productivity Developer productivity related (how to improve development) kind/enhancement Enhancement, improvement, extension labels May 16, 2024
@gardener-prow gardener-prow bot requested review from ary1992 and timebertt May 16, 2024 16:43
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2024
Copy link
Contributor

gardener-prow bot commented May 16, 2024

Hi @maboehm. Thanks for your PR.

I'm waiting for a gardener member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@gardener-prow gardener-prow bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label May 16, 2024
# always add VERSION file
echo "VERSION" >> "$path_actual_dependencies"
# add vendor if the vendor/ dir exists
if [[ -d "$repo_root/vendor" ]]; then
echo "vendor" >> "$path_actual_dependencies"
fi

# sort dependencies
sort -fo "$path_current_skaffold_dependencies"{,}
Copy link
Contributor Author

@maboehm maboehm May 16, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: IMO we should not sort the dependencies that we retrieved from the current config, so I removed this

@timebertt
Copy link
Member

/ok-to-test

@gardener-prow gardener-prow bot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 16, 2024
Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Thank you!

/lgtm
/approve
/retest

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 21, 2024
Copy link
Contributor

gardener-prow bot commented May 21, 2024

LGTM label has been added.

Git tree hash: 9b6fc442bbdd6991f7d13c3168975dad6d56f48b

Copy link
Contributor

gardener-prow bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
Copy link
Contributor

gardener-prow bot commented May 21, 2024

@maboehm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-e2e-kind-ha-single-zone-upgrade 344e5c4 link unknown /test pull-gardener-e2e-kind-ha-single-zone-upgrade

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@maboehm
Copy link
Contributor Author

maboehm commented May 21, 2024

/retest

@gardener-prow gardener-prow bot merged commit 3edc630 into gardener:master May 21, 2024
18 checks passed
@maboehm maboehm deleted the skaffold-embed branch May 21, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dev-productivity Developer productivity related (how to improve development) cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants