Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes for deployment of VPN2 after rewrite to Go. #9774

Draft
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

MartinWeindel
Copy link
Member

How to categorize this PR?

/area control-plane
/kind enhancement

What this PR does / why we need it:
The rewrite of the bash scripts to Go in vpn2 brings some changes in the deployment of the vpn-seed-server and vpn-shoot-client deployments.
These adjustments must be applied together with the new release of VPN2 containing the rewrite to Go (see PR gardener/vpn2#84)

Co-authored-by: @dergeberl
Co-authored-by: @hown3d
Co-authored-by: @mreiger

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

Release note:

Changes for deployment of VPN2 after rewrite to Go.

Copy link
Contributor

gardener-prow bot commented May 16, 2024

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

@gardener-prow gardener-prow bot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/control-plane Control plane related kind/enhancement Enhancement, improvement, extension labels May 16, 2024
@gardener-prow gardener-prow bot requested review from shafeeqes and timuthy May 16, 2024 15:16
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels May 16, 2024
@gardener-prow gardener-prow bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label May 28, 2024
Copy link
Contributor

gardener-prow bot commented Jun 6, 2024

@MartinWeindel: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-gardener-e2e-kind-operator-seed 5eb0c21 link true /test pull-gardener-e2e-kind-operator-seed

Full PR test history. Your PR dashboard. Command help for this repository.
Please help us cut down on flakes by linking this test failure to an open flake report or filing a new flake report if you can't find an existing one. Also see our testing guideline for how to avoid and hunt flakes.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@gardener-prow gardener-prow bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jun 6, 2024
Copy link
Contributor

gardener-prow bot commented Jun 10, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Signed-off-by: Lukas Hoehl <lukas.hoehl@stackit.de>
Copy link
Contributor

gardener-prow bot commented Jun 10, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign shafeeqes for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/control-plane Control plane related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. kind/enhancement Enhancement, improvement, extension needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants