-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
extensions lib: Drop the EnsureKubeAPIServerService
func from the controlplane Ensurer
#9770
extensions lib: Drop the EnsureKubeAPIServerService
func from the controlplane Ensurer
#9770
Conversation
…ontrolplane `Ensurer`
/lgtm Should we also add text to the release note to instruct extension maintainers that https://github.com/gardener/gardener-extension-provider-aws/blob/aaf1ad53dfb45a14c63662f36611bb239f32bc2d/pkg/webhook/controlplaneexposure/add.go#L41 should be removed when revendoring this change for extensions not in the |
LGTM label has been added. Git tree hash: f1f14e546dec62ad4ea4ae988e194bfe35b169f5
|
Makes sense, thanks! I now added a new release note to the PR. For the provider extensions in the gardener org I raised the corresponding PRs - see gardener/gardener-extension-provider-aws#952 and all linked PRs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for cleaning up :)
/approve
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: rfranzke The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
How to categorize this PR?
/area scalability
/kind cleanup
What this PR does / why we need it:
See the motivation in #9755
Which issue(s) this PR fixes:
Fixes #9755
Special notes for your reviewer:
N/A
Release note: