Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

extensions lib: Drop the EnsureKubeAPIServerService func from the controlplane Ensurer #9770

Merged

Conversation

ialidzhikov
Copy link
Member

@ialidzhikov ialidzhikov commented May 16, 2024

How to categorize this PR?

/area scalability
/kind cleanup

What this PR does / why we need it:
See the motivation in #9755

Which issue(s) this PR fixes:
Fixes #9755

Special notes for your reviewer:
N/A

Release note:

The `github.com/gardener/gardener/extensions/pkg/webhook/controlplane/genericmutator.Ensurer#EnsureKubeAPIServerService` func is removed. This func was used before the introduction of `ManagedIstio`/`APIServerSNI` (when the kube-apiserver Service was of type LoadBalancer) to set cloud provider specific annotations to the Service. However, after `ManagedIstio`/`APIServerSNI` are unconditionally enabled (the kube-apiserver Service is of type ClusterIP) this func is no longer used. Nowadays, istio-ingressgateway Service annotations can be provided via the Seed spec.
With the removal of the `github.com/gardener/gardener/extensions/pkg/webhook/controlplane/genericmutator.Ensurer#EnsureKubeAPIServerService` func, the provider extensions using the `genericmutator.Ensurer` no longer need to mutate Services and should no longer mutate Services to prevent no-op webhook invocations.

@gardener-prow gardener-prow bot added area/scalability Scalability related kind/cleanup Something that is not needed anymore and can be cleaned up labels May 16, 2024
@gardener-prow gardener-prow bot requested review from ary1992 and timebertt May 16, 2024 12:11
@gardener-prow gardener-prow bot added cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 16, 2024
@plkokanov
Copy link
Contributor

plkokanov commented May 17, 2024

/lgtm

Should we also add text to the release note to instruct extension maintainers that https://github.com/gardener/gardener-extension-provider-aws/blob/aaf1ad53dfb45a14c63662f36611bb239f32bc2d/pkg/webhook/controlplaneexposure/add.go#L41 should be removed when revendoring this change for extensions not in the gardener org: e.g. https://github.com/metal-stack/gardener-extension-provider-metal/blob/6dfa3254b70484c68dcd1705ad159fa9e978bbb2/pkg/webhook/controlplaneexposure/add.go#L37

@gardener-prow gardener-prow bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
Copy link
Contributor

gardener-prow bot commented May 17, 2024

LGTM label has been added.

Git tree hash: f1f14e546dec62ad4ea4ae988e194bfe35b169f5

@ialidzhikov
Copy link
Member Author

Should we also add text to the release note to instruct extension maintainers that https://github.com/gardener/gardener-extension-provider-aws/blob/aaf1ad53dfb45a14c63662f36611bb239f32bc2d/pkg/webhook/controlplaneexposure/add.go#L41 should be removed when revendoring this change for extensions not in the gardener org: e.g. https://github.com/metal-stack/gardener-extension-provider-metal/blob/6dfa3254b70484c68dcd1705ad159fa9e978bbb2/pkg/webhook/controlplaneexposure/add.go#L37

Makes sense, thanks! I now added a new release note to the PR. For the provider extensions in the gardener org I raised the corresponding PRs - see gardener/gardener-extension-provider-aws#952 and all linked PRs.

Copy link
Member

@rfranzke rfranzke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for cleaning up :)
/approve

Copy link
Contributor

gardener-prow bot commented May 21, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: rfranzke

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gardener-prow gardener-prow bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 21, 2024
@gardener-prow gardener-prow bot merged commit dcf0191 into gardener:master May 21, 2024
18 checks passed
@ialidzhikov ialidzhikov deleted the drop/EnsureKubeAPIServerService branch May 27, 2024 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/scalability Scalability related cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/cleanup Something that is not needed anymore and can be cleaned up lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
3 participants