Move rlimit calls into NativeAccess #108805
Conversation
This commit moves getting max threads, max virtual memory size, and max file size into NativeAccess. relates elastic#104876
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
| @@ -16,10 +16,20 @@ class LinuxNativeAccess extends PosixNativeAccess { | |||
| Systemd systemd; | |||
|
|
|||
| LinuxNativeAccess(NativeLibraryProvider libraryProvider) { | |||
| super("Linux", libraryProvider); | |||
| super("Linux", libraryProvider, new PosixConstants(-1L, 9, 1)); | |||
There was a problem hiding this comment.
i wonder if it would be more readable to have those numbers as constants (like here https://github.com/elastic/elasticsearch/pull/108805/files#diff-e911107fc6225d34875cc491c2024e2eb415a4817a86d96b9b331cff63408da7R18 perhaps?
or at least with a comment
There was a problem hiding this comment.
It's pretty readable in intellij (it shows the parameter name). I want to avoid creating individual static constants for each because they would just be passed through in this constants object, which is also statically held, meaning they would be in memory twice for no good reason.
| @@ -326,10 +326,6 @@ public boolean handle(int code) { | |||
| // we've already logged this. | |||
| } | |||
|
|
|||
| Natives.trySetMaxNumberOfThreads(); | |||
There was a problem hiding this comment.
was this previously was 'caching' maxNumberOfThreads, MaxSizeVirtualMemory etc?
Do we want to do something similar with this refactoring?
There was a problem hiding this comment.
Previously these try methods were called here, which set the values returned from rlimit in global statics in JNANatives. Now these values are retrieved during construction of NativeAccess instead of explicitly. By doing it during construction they do not need to be mutable as they were before.
rjernst
added
the
auto-merge
This commit moves getting max threads, max virtual memory size, and max file size into NativeAccess. relates elastic#104876
This commit moves getting max threads, max virtual memory size, and max file size into NativeAccess.
relates #104876