kvpb: remove deprecated fields from BulkOpSummary #124389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
These fields aren't actually used and haven't been for several years now. Epic: None Release note: None
yuzefovich
force-pushed
the
bulk-op-summary
branch
from
45ae891
to
5a3f320
Compare
yuzefovich
requested review from
RaduBerinde and
dt
and removed request for
RaduBerinde
stevendanna
approved these changes
May 30, 2024
|
TFTR! bors r+ |
craig bot
pushed a commit
that referenced
this pull request
May 30, 2024
124389: kvpb: remove deprecated fields from BulkOpSummary r=yuzefovich a=yuzefovich These fields aren't actually used and haven't been for several years now. Epic: None Release note: None 124865: acceptance: use `docker compose` r=rickystewart a=rail Previously, we used `docker-compose` (V1) to run acceptance tests. `docker compose` is a plugin now and not a separate command, which supports V2 compose files. See https://docs.docker.com/compose/migrate/#what-are-the-differences-between-compose-v1-and-compose-v2 for the details. Epic: none Release note: None Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com> Co-authored-by: Rail Aliiev <rail@iqchoice.com>
|
Build failed (retrying...): |
|
bors r+ |
|
Already running a review |
craig bot
pushed a commit
that referenced
this pull request
May 30, 2024
124389: kvpb: remove deprecated fields from BulkOpSummary r=yuzefovich a=yuzefovich These fields aren't actually used and haven't been for several years now. Epic: None Release note: None 124681: sql: add information about which KV nodes served read requests r=rickystewart a=yuzefovich This PR exposes information in EXPLAIN ANALYZE output about which KV nodes participated in evaluating read requests. See each commit for details. Fixes: #91774. Co-authored-by: Yahor Yuzefovich <yahor@cockroachlabs.com>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These fields aren't actually used and haven't been for several years now.
Epic: None
Release note: None