Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

*: remove all version checks against 23.2 #124372

Merged
merged 1 commit into from
May 23, 2024
Merged

*: remove all version checks against 23.2 #124372

merged 1 commit into from
May 23, 2024

Conversation

RaduBerinde
Copy link
Member

Now that MinSupported is V23_2, we no longer need to check if 23.2
is active. This change removes all these checks.

Epic: none
Release note: None

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@RaduBerinde RaduBerinde marked this pull request as ready for review May 17, 2024 23:43
@RaduBerinde RaduBerinde requested review from a team as code owners May 17, 2024 23:43
@RaduBerinde RaduBerinde requested review from nameisbhaskar, vidit-bhat, dt, michae2, rail and celiala and removed request for a team May 17, 2024 23:43
@RaduBerinde RaduBerinde changed the title remove all version checks against 23.2 *: remove all version checks against 23.2 May 17, 2024
@RaduBerinde
Copy link
Member Author

Friendly ping

celiala
celiala approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@celiala celiala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Appreciate the clean up! :lgtm:

Reviewed 36 of 36 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt, @michae2, @nameisbhaskar, @rail, and @vidit-bhat)

rafiss
rafiss approved these changes May 22, 2024
View reviewed changes
Copy link
Collaborator

@rafiss rafiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @dt, @michae2, @nameisbhaskar, @RaduBerinde, @rail, and @vidit-bhat)

pkg/sql/catalog/tabledesc/validate.go line 980 at r1 (raw file):

	// initialized to validate the storage parameters.
	vea.Report(ValidateTTLExpirationExpr(desc))
	vea.Report(ValidateTTLExpirationColumn(desc, true /* allowDescPK */))

nit: this bool param can be removed

@RaduBerinde
*: remove all version checks against 23.2
e5b30e4 
Now that `MinSupported` is `V23_2`, we no longer need to check if 23.2
is active. This change removes all these checks.

Epic: none
Release note: None
RaduBerinde
RaduBerinde commented May 22, 2024
View reviewed changes
Copy link
Member Author

@RaduBerinde RaduBerinde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TFTRs!

Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (and 1 stale) (waiting on @celiala, @dt, @michae2, @nameisbhaskar, @rail, and @vidit-bhat)

pkg/sql/catalog/tabledesc/validate.go line 980 at r1 (raw file):

Previously, rafiss (Rafi Shamim) wrote…

nit: this bool param can be removed

Done.

@RaduBerinde
Copy link
Member Author

bors r+

@craig
Copy link
Contributor

craig bot commented May 23, 2024

Build succeeded:

@craig craig bot merged commit f48c4d5 into cockroachdb:master May 23, 2024
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafiss rafiss rafiss approved these changes

@celiala celiala celiala approved these changes

@nameisbhaskar nameisbhaskar Awaiting requested review from nameisbhaskar nameisbhaskar is a code owner automatically assigned from cockroachdb/test-eng

@vidit-bhat vidit-bhat Awaiting requested review from vidit-bhat vidit-bhat is a code owner automatically assigned from cockroachdb/test-eng

@dt dt Awaiting requested review from dt dt is a code owner automatically assigned from cockroachdb/disaster-recovery

@michae2 michae2 Awaiting requested review from michae2 michae2 is a code owner automatically assigned from cockroachdb/sql-queries-prs

@rail rail Awaiting requested review from rail

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@RaduBerinde @cockroach-teamcity @rafiss @celiala