roachtest: add a new cdc/kafka-chaos-single-row test #124313
Conversation
andyyang890
requested review from
nameisbhaskar and
vidit-bhat
and removed request for
a team
|
This change is |
|
This PR depends on #124195 |
There was a problem hiding this comment.
Reviewable status:
complete! 1 of 0 LGTMs obtained (waiting on @andyyang890, @asg0451, @nameisbhaskar, and @vidit-bhat)
pkg/cmd/roachtest/tests/cdc.go line 1578 at r5 (raw file):
Leases: registry.MetamorphicLeases, CompatibleClouds: registry.AllExceptAWS, // TODO(yang): Add this to the nightly test suite after we fix the Kafka restart bug.
nit: s/yang/#122372
pkg/cmd/roachtest/tests/cdc.go line 1626 at r5 (raw file):
stmt := fmt.Sprintf(`UPDATE t SET x = %d WHERE id = 1;`, i) if i == 0 { stmt = fmt.Sprintf(`INSERT INTO t VALUES (1, %d);`, i)
Consider lifting the insert statement and its execution out of the loop.
|
Please wait for @asg0451 to have a chance to review before merging. Thanks! |
andyyang890
force-pushed
the
kafka-restarts-test
branch
from
0bd0c44
to
859b31a
Compare
There was a problem hiding this comment.
Reviewable status:
pkg/cmd/roachtest/tests/cdc.go line 1578 at r5 (raw file):
Previously, rharding6373 (Rachael Harding) wrote…
nit: s/yang/#122372
Done.
pkg/cmd/roachtest/tests/cdc.go line 1626 at r5 (raw file):
Previously, rharding6373 (Rachael Harding) wrote…
Consider lifting the insert statement and its execution out of the loop.
Done.
andyyang890
force-pushed
the
kafka-restarts-test
branch
from
859b31a
to
944f9ec
Compare
This patch adds a new `cdc/kafka-chaos-single-row` roachtest, which will serve as a regression test for the Kafka restarts bug. It is currently configured to only be able to run manually since we have not yet fixed the bug. Release note: None
andyyang890
force-pushed
the
kafka-restarts-test
branch
from
944f9ec
to
902fb69
Compare
There was a problem hiding this comment.
Reviewed 3 of 4 files at r6, 1 of 1 files at r7, all commit messages.
Reviewable status:
|
TFTRs! bors r=rharding6373,asg0451 |
This patch adds a new
cdc/kafka-chaos-single-rowroachtest, whichwill serve as a regression test for the Kafka restarts bug. It is
currently configured to only be able to run manually since we have not
yet fixed the bug.
Informs #122372
Release note: None