Bump actions/checkout to v4 for GHA #7284
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #7284 +/- ##
==========================================
- Coverage 93.22% 93.21% -0.02%
==========================================
Files 275 275
Lines 59528 59572 +44
Branches 0 7422 +7422
==========================================
+ Hits 55495 55529 +34
- Misses 4033 4043 +10 |
gokhangulbiz
force-pushed
the
gokhangulbiz/gha-checkout-version-bump
branch
from
e436d61
to
5c86cd2
Compare
gokhangulbiz
changed the title
JelteF
reviewed
Oct 30, 2023
There was a problem hiding this comment.
PR should have decent description instead of the template. A simple sentence explaining why we need this change is enough in this case. You can also remove the DESCRIPTION line completely though, since that is used to generate the changelog for user facing changes.
Also left one comment. Other than that this looks fine.
| @@ -39,10 +39,10 @@ jobs: | |||
| needs: params | |||
| runs-on: ubuntu-20.04 | |||
| container: | |||
| image: ${{ needs.params.outputs.build_image_name }}:latest | |||
There was a problem hiding this comment.
Why is this needed? It seem unrelated. If it is needed, then that's something that would be helpful to explain in the PR description.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DESCRIPTION: PR description that will go into the change log, up to 78 characters