[SPARK-48323][SQL] DB2: Map BooleanType to BOOLEAN instead of CHAR(1) #46637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @dongjoon-hyun @cloud-fan @LuciferYang thanks |
|
Due to the existence of |
Thank you @LuciferYang for the reminder. I missed that. |
LuciferYang
approved these changes
May 20, 2024
|
Merged to master. Thank you @LuciferYang |
|
late LGTM |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
This PR maps BooleanType to BOOLEAN instead of CHAR(1) when writing DB2 tables, users can restore the old behavior by setting spark.sql.legacy.db2.booleanTypeMapping.enabled to true
Why are the changes needed?
DB2 has supported boolean since v9.7, which is already EOL. It's reasonable to BooleanType to BOOLEAN
Does this PR introduce any user-facing change?
yes, spark.sql.legacy.db2.booleanTypeMapping.enabled is provided to restore
How was this patch tested?
new tests
Was this patch authored or co-authored using generative AI tooling?
no