app/vmalert: support DNS SRV record in -remoteWrite.url
#6299
Conversation
lib/httputils/statconn.go
Outdated
| // and register stats metrics for conns. | ||
| func GetStatDialFunc(metricPrefix string) func(ctx context.Context, network, addr string) (net.Conn, error) { | ||
| metricSetRegister.Do(func() { | ||
| dialsTotal = metrics.NewCounter(fmt.Sprintf(`%s_dials_total`, metricPrefix)) |
There was a problem hiding this comment.
do we need custom metric name for each component?
There was a problem hiding this comment.
Why not? I think it is useful to have these metrics, unless they start to collide.
There was a problem hiding this comment.
imho finding needed data on grafana is easier, when you have a static metric name with different label values
There was a problem hiding this comment.
I think differently, when you know which metric you wanna use, having different metricName or different labels with same metricName are the same.
But when you can't remember the exact metricName, using auto-complete, having specific metricName prefix like remotewrite or remoteread can help to find metrics that component exposes for specific feature.
lib/httputils/statconn.go
Outdated
| // and register stats metrics for conns. | ||
| func GetStatDialFunc(metricPrefix string) func(ctx context.Context, network, addr string) (net.Conn, error) { | ||
| metricSetRegister.Do(func() { | ||
| dialsTotal = metrics.NewCounter(fmt.Sprintf(`%s_dials_total`, metricPrefix)) |
There was a problem hiding this comment.
Why not? I think it is useful to have these metrics, unless they start to collide.
I think flag description is pretty clear for vmalert here, since DNS SRV record is a common term and extra chapter in doc won't contain any extra message. |
Haleygo
force-pushed
the
gh-6053
branch
3 times, most recently
from
8e2b71d
to
691bf6f
Compare
Signed-off-by: hagen1778 <roman@victoriametrics.com>
part of #6053, supports [DNS SRV](https://en.wikipedia.org/wiki/SRV_record) address in `-remoteWrite.url` command-line option. (cherry picked from commit d7b5062)
Describe Your Changes
part of #6053,
supports DNS SRV address in
-remoteWrite.urlcommand-line option.Checklist
The following checks are mandatory: