Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BugFix] Fix session context excution id #45810

Merged
merged 2 commits into from
May 20, 2024
Merged

[BugFix] Fix session context excution id #45810

merged 2 commits into from
May 20, 2024

Conversation

meegoo
Copy link
Contributor

@meegoo meegoo commented May 17, 2024 •
edited

Why I'm doing:

broker load is async task, can not set execution id for session context

What I'm doing:

Fixes https://github.com/StarRocks/StarRocksTest/issues/7365

What type of PR is this:

  • BugFix
  • Feature
  • Enhancement
  • Refactor
  • UT
  • Doc
  • Tool

Does this PR entail a change in behavior?

  • Yes, this PR will result in a change in behavior.
  • No, this PR will not result in a change in behavior.

If yes, please specify the type of change:

  • Interface/UI changes: syntax, type conversion, expression evaluation, display information
  • Parameter changes: default values, similar parameters but with different default values
  • Policy changes: use new policy to replace old one, functionality automatically enabled
  • Feature removed
  • Miscellaneous: upgrade & downgrade compatibility, etc.

Checklist:

  • I have added test cases for my bug fix or my new feature
  • This pr needs user documentation (for new or modified features or behaviors)
    • I have added documentation for my new feature or new function
  • This is a backport pr

Bugfix cherry-pick branch check:

  • I have checked the version labels which the pr will be auto-backported to the target branch
    • 3.3
    • 3.2
    • 3.1
    • 3.0
    • 2.5

@mergify mergify bot assigned meegoo May 17, 2024
@meegoo
[BugFix] Fix session context excution id
80159be 
Signed-off-by: meegoo <meegoo.sr@gmail.com>
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented May 20, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@wyb wyb enabled auto-merge (squash) May 20, 2024 07:50
@github-actions GitHub Actions
Copy link

[BE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@github-actions GitHub Actions
Copy link

[FE Incremental Coverage Report]

✅ pass : 0 / 0 (0%)

@wyb wyb merged commit cf8624c into StarRocks:main May 20, 2024
49 checks passed
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.3

@github-actions github-actions bot removed the 3.3 label May 20, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.2

@github-actions github-actions bot removed the 3.2 label May 20, 2024
@github-actions GitHub Actions
Copy link

@Mergifyio backport branch-3.1

@github-actions github-actions bot removed the 3.1 label May 20, 2024
@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2024 •
edited

backport branch-3.3

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2024 •
edited

backport branch-3.2

✅ Backports have been created

@mergify Mergify
Copy link
Contributor

mergify bot commented May 20, 2024 •
edited

backport branch-3.1

✅ Backports have been created

mergify bot pushed a commit that referenced this pull request May 20, 2024
@meegoo @mergify
[BugFix] Fix session context excution id (#45810)
1e9af05 
Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit cf8624c)
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request May 20, 2024
@meegoo @mergify
[BugFix] Fix session context excution id (#45810)
8ffcbc5 
Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit cf8624c)
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
42 tasks
mergify bot pushed a commit that referenced this pull request May 20, 2024
@meegoo @mergify
[BugFix] Fix session context excution id (#45810)
21f6d1b 
Signed-off-by: meegoo <meegoo.sr@gmail.com>
(cherry picked from commit cf8624c)

# Conflicts:
#	fe/fe-core/src/main/java/com/starrocks/load/loadv2/BrokerLoadJob.java
@mergify mergify bot mentioned this pull request May 20, 2024
Merged
42 tasks
wanpengfei-git pushed a commit that referenced this pull request May 20, 2024
@mergify @meegoo
[BugFix] Fix session context excution id (backport #45810) (#45929)
be85ee8 
Co-authored-by: meegoo <meegoo.sr@gmail.com>
wanpengfei-git pushed a commit that referenced this pull request May 20, 2024
@mergify @meegoo
[BugFix] Fix session context excution id (backport #45810) (#45928)
7f03b6f 
Co-authored-by: meegoo <meegoo.sr@gmail.com>
meegoo added a commit that referenced this pull request May 20, 2024
@mergify @meegoo
[BugFix] Fix session context excution id (backport #45810) (#45930)
e9927ef 
Signed-off-by: meegoo <meegoo.sr@gmail.com>
Co-authored-by: meegoo <meegoo.sr@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyb wyb wyb approved these changes

@rickif rickif rickif approved these changes

@gengjun-git gengjun-git gengjun-git approved these changes

Assignees

@meegoo meegoo

Labels
3.1-merged 3.2-merged 3.3-merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@meegoo @wyb @rickif @gengjun-git