Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Java 8 as source and target versions #49

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pfichtner
Copy link

The current JSONDB version only runs under Java 10 because it was compiled with or for Java 10. In fact, there is no reason for this: JSONDB itself does not use Java features greater than 8 and even no dependencies require a higher Java version than 8. So only the source/targets settings prevents the use of JSONDB in environments where Java 8 is set.

@FarooqKhan
Copy link
Collaborator

I built and released jsondb with both java8 and java 11

built with java 11.
https://mvnrepository.com/artifact/io.jsondb/jsondb-core/1.0.115-j11

built with java 8
https://mvnrepository.com/artifact/io.jsondb/jsondb-core/1.0.115-j8

@FarooqKhan
Copy link
Collaborator

Thankyou for the pull request, but this change worries me a bit about how it impacts everyone else.

@pfichtner
Copy link
Author

Thanks for accepting the PR although I don't understand why there are now two versions of jsondb.
The version built with Java8 can be used with every JRE >= 8 since Java is backward compatible. You only have to use higher Java versions if your code uses newer features. Since your project can be built using JDK 8 this clearly indicates, that you are not using any Java features newer than Java 8.
There is no impact for anybody (beside that projects that depend on Java 8,9 can now use jsondb as well).

@FarooqKhan
Copy link
Collaborator

@pfichtner I have not merged the PR because I don't see a reason to merge. The current code should compile with Java 8 as well as any later version. If you want to use the library under java 8 you should use the https://mvnrepository.com/artifact/io.jsondb/jsondb-core/1.0.115-j8
This has been available since Mar 2020.

@pfichtner
Copy link
Author

@FarooqKhan Oh! Thanks didn't realize that there is a separate version available, thanks for the hint. But what makes me curious is: What's the difference of that two versions (beside that the class files versions differ 52 vs 55), so what's the reason for binary jar jsondb-core-j11?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants