-
Notifications
You must be signed in to change notification settings - Fork 6.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix sanitizers #64090
Fix sanitizers #64090
Conversation
This is an automated comment for commit 64a3080 with description of existing statuses. It's updated for the latest CI running ❌ Click here to open a full report in a separate page
Successful checks
|
Different attempt: |
Interesting, builds passed, but stateless tests failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure what needs to be done to rebuild AMI.
Maybe this will help after these steps.
Actually I don't see that it helps, at least not 100%, so I'm still looking for a solution |
Interesting, looks like it helped - TSan and MSan builded and stateless tests passed |
v1: vm.mmap_rnd_bits=28 v2: rebase with clang 18.1.6 + kernel.randomize_va_space=0 v3: leave only vm.mmap_rnd_bits=28 + use pre-run.sh (hope that it will be used), that way docker will not require --privileged and by some reason this breaks ASAN (though I cannot reproduce it) v4: use actions/common_setup over init_runner.sh (it requires some manual deploy)
Here are all the VM changes made to the AMI on Friday
I'm sorry about that. The update was made based on the hard deprecation of the actions runner. This deprecation will be effective this coming Thursday. If it helps, we can deploy a new AMI tomorrow. There's another tiny fix to deploy. |
Yes, this is exactly the reason.
No problem; maybe more visibility of AMI updates is needed. |
…0f9be273ebfb00e24faf42194fd41 Cherry pick #64090 to 24.2: Fix sanitizers
…0f9be273ebfb00e24faf42194fd41 Cherry pick #64090 to 24.3: Fix sanitizers
…0f9be273ebfb00e24faf42194fd41 Cherry pick #64090 to 24.4: Fix sanitizers
Backport #64090 to 24.3: Fix sanitizers
Backport #64090 to 24.4: Fix sanitizers
Backport #64090 to 24.2: Fix sanitizers
…0f9be273ebfb00e24faf42194fd41 Cherry pick #64090 to 23.8: Fix sanitizers
Let's start with a manual |
Since likely the image will not be updated from CI, on other words it doesn't looks like the part that I could run by myself, I've changed couple of other places to test will this helps or not within PR.
Changelog category (leave one):
Fixes: #64086
Cc: @Felixoid (if this will work, can you please update the image)