Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sanitizers #64090

Merged
merged 1 commit into from
May 20, 2024
Merged

Fix sanitizers #64090

merged 1 commit into from
May 20, 2024

Conversation

azat
Copy link
Collaborator

@azat azat commented May 18, 2024

Since likely the image will not be updated from CI, on other words it doesn't looks like the part that I could run by myself, I've changed couple of other places to test will this helps or not within PR.

Changelog category (leave one):

  • Not for changelog (changelog entry is not required)

Fixes: #64086
Cc: @Felixoid (if this will work, can you please update the image)

@robot-ch-test-poll robot-ch-test-poll added the pr-not-for-changelog This PR should not be mentioned in the changelog label May 18, 2024
@robot-ch-test-poll
Copy link
Contributor

robot-ch-test-poll commented May 18, 2024

This is an automated comment for commit 64a3080 with description of existing statuses. It's updated for the latest CI running

❌ Click here to open a full report in a separate page

Check nameDescriptionStatus
CI runningA meta-check that indicates the running CI. Normally, it's in success or pending state. The failed status indicates some problems with the PR⏳ pending
Mergeable CheckChecks if all other necessary checks are successful❌ failure
Stateless testsRuns stateless functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc❌ failure
Successful checks
Check nameDescriptionStatus
A SyncThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
AST fuzzerRuns randomly generated queries to catch program errors. The build type is optionally given in parenthesis. If it fails, ask a maintainer for help✅ success
ClickBenchRuns [ClickBench](https://github.com/ClickHouse/ClickBench/) with instant-attach table✅ success
ClickHouse build checkBuilds ClickHouse in various configurations for use in further steps. You have to fix the builds that fail. Build logs often has enough information to fix the error, but you might have to reproduce the failure locally. The cmake options can be found in the build log, grepping for cmake. Use these options and follow the general build process✅ success
Compatibility checkChecks that clickhouse binary runs on distributions with old libc versions. If it fails, ask a maintainer for help✅ success
Docker keeper imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docker server imageThe check to build and optionally push the mentioned image to docker hub✅ success
Docs checkBuilds and tests the documentation✅ success
Fast testNormally this is the first check that is ran for a PR. It builds ClickHouse and runs most of stateless functional tests, omitting some. If it fails, further checks are not started until it is fixed. Look at the report to see which tests fail, then reproduce the failure locally as described here✅ success
Flaky testsChecks if new added or modified tests are flaky by running them repeatedly, in parallel, with more randomization. Functional tests are run 100 times with address sanitizer, and additional randomization of thread scheduling. Integrational tests are run up to 10 times. If at least once a new test has failed, or was too long, this check will be red. We don't allow flaky tests, read the doc✅ success
Install packagesChecks that the built packages are installable in a clear environment✅ success
Integration testsThe integration tests report. In parenthesis the package type is given, and in square brackets are the optional part/total tests✅ success
PR CheckThere's no description for the check yet, please add it to tests/ci/ci_config.py:CHECK_DESCRIPTIONS✅ success
Performance ComparisonMeasure changes in query performance. The performance test report is described in detail here. In square brackets are the optional part/total tests✅ success
Stateful testsRuns stateful functional tests for ClickHouse binaries built in various configurations -- release, debug, with sanitizers, etc✅ success
Stress testRuns stateless functional tests concurrently from several clients to detect concurrency-related errors✅ success
Style checkRuns a set of checks to keep the code style clean. If some of tests failed, see the related log from the report✅ success
Unit testsRuns the unit tests for different release types✅ success
Upgrade checkRuns stress tests on server version from last release and then tries to upgrade it to the version from the PR. It checks if the new server can successfully startup without any errors, crashes or sanitizer asserts✅ success

@azat
Copy link
Collaborator Author

azat commented May 18, 2024

Different attempt:

@azat azat marked this pull request as draft May 18, 2024 17:31
@azat
Copy link
Collaborator Author

azat commented May 18, 2024

Interesting, builds passed, but stateless tests failed

Copy link
Member

@alexey-milovidov alexey-milovidov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure what needs to be done to rebuild AMI.
Maybe this will help after these steps.

@alexey-milovidov alexey-milovidov self-assigned this May 19, 2024
@azat
Copy link
Collaborator Author

azat commented May 19, 2024

Actually I don't see that it helps, at least not 100%, so I'm still looking for a solution

@azat
Copy link
Collaborator Author

azat commented May 19, 2024

Interesting, looks like it helped - TSan and MSan builded and stateless tests passed

docker/packager/packager Outdated Show resolved Hide resolved
@azat azat changed the title Apply some quirks to workaround issues with sanitizers Fix sanitizers May 19, 2024
v1: vm.mmap_rnd_bits=28
v2: rebase with clang 18.1.6 + kernel.randomize_va_space=0
v3: leave only vm.mmap_rnd_bits=28 + use pre-run.sh (hope that it will
    be used), that way docker will not require --privileged and by some
    reason this breaks ASAN (though I cannot reproduce it)
v4: use actions/common_setup over init_runner.sh (it requires some
    manual deploy)
@azat azat marked this pull request as ready for review May 19, 2024 21:01
@alesapin
Copy link
Member

It's strange that some tests fail with weird error:

image

@Felixoid
Copy link
Member

Felixoid commented May 19, 2024

Here are all the VM changes made to the AMI on Friday

> git diff --word-diff /tmp/sysctl.{old,new} | grep '+}' | grep vm.
vm.min_free_kbytes = [-45056-]{+67584+}
vm.mmap_rnd_bits = [-28-]{+32+}
vm.mmap_rnd_compat_bits = [-8-]{+16+}
vm.user_reserve_kbytes = [-52114-]{+131072+}

I'm sorry about that. The update was made based on the hard deprecation of the actions runner. This deprecation will be effective this coming Thursday.

If it helps, we can deploy a new AMI tomorrow. There's another tiny fix to deploy.

@alexey-milovidov alexey-milovidov merged commit 53545b5 into ClickHouse:master May 20, 2024
136 of 167 checks passed
@alexey-milovidov
Copy link
Member

vm.mmap_rnd_bits = [-28-]{+32+}
vm.mmap_rnd_compat_bits = [-8-]{+16+}

Yes, this is exactly the reason.

I'm sorry about that. The update was made based on the hard deprecation of the actions runner. This deprecation will be effective this coming Thursday.

No problem; maybe more visibility of AMI updates is needed.

@robot-ch-test-poll4 robot-ch-test-poll4 added the pr-synced-to-cloud The PR is synced to the cloud repo label May 20, 2024
@azat azat deleted the fix-sanitizers branch May 20, 2024 05:37
@alesapin alesapin added pr-must-backport-cloud pr-must-backport Pull request should be backported intentionally. Use this label with great care! labels May 20, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request May 20, 2024
…0f9be273ebfb00e24faf42194fd41

Cherry pick #64090 to 24.2: Fix sanitizers
robot-clickhouse added a commit that referenced this pull request May 20, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request May 20, 2024
…0f9be273ebfb00e24faf42194fd41

Cherry pick #64090 to 24.3: Fix sanitizers
robot-clickhouse added a commit that referenced this pull request May 20, 2024
robot-clickhouse-ci-1 added a commit that referenced this pull request May 20, 2024
…0f9be273ebfb00e24faf42194fd41

Cherry pick #64090 to 24.4: Fix sanitizers
robot-clickhouse added a commit that referenced this pull request May 20, 2024
alexey-milovidov added a commit that referenced this pull request May 20, 2024
alexey-milovidov added a commit that referenced this pull request May 20, 2024
alexey-milovidov added a commit that referenced this pull request May 20, 2024
robot-ch-test-poll2 added a commit that referenced this pull request May 20, 2024
…0f9be273ebfb00e24faf42194fd41

Cherry pick #64090 to 23.8: Fix sanitizers
robot-clickhouse added a commit that referenced this pull request May 20, 2024
@robot-ch-test-poll2 robot-ch-test-poll2 added the pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore label May 20, 2024
@Felixoid
Copy link
Member

Let's start with a manual comp-ci-ami-updated label. Then we'll try to automate it

@Felixoid Felixoid added the comp-ci-ami-updated The runner's AMI is updated from this PR label May 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
comp-ci-ami-updated The runner's AMI is updated from this PR pr-backports-created Backport PRs are successfully created, it won't be processed by CI script anymore pr-backports-created-cloud pr-must-backport Pull request should be backported intentionally. Use this label with great care! pr-must-backport-cloud pr-not-for-changelog This PR should not be mentioned in the changelog pr-synced-to-cloud The PR is synced to the cloud repo
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TSan/MSan builds failures
8 participants