{"payload":{"feedbackUrl":"https://github.com/orgs/community/discussions/53140","repo":{"id":34820885,"defaultBranch":"master","name":"reliance-edge","ownerLogin":"tuxera","currentUserCanPush":false,"isFork":false,"isEmpty":false,"createdAt":"2015-04-29T22:09:58.000Z","ownerAvatar":"https://avatars.githubusercontent.com/u/699213?v=4","public":true,"private":false,"isOrgOwned":true},"refInfo":{"name":"","listCacheKey":"v0:1644260437.586273","currentOid":""},"activityList":{"items":[{"before":"8a1d178dd4633b364e367ecda2b569cf2fea9ca5","after":"147f5683e9120385159d06c4c5c2edb4daf6f622","ref":"refs/heads/master","pushedAt":"2024-01-27T00:54:14.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"linux: use relative directory paths in Makefile\n\nP_PROJDIR and P_BASEDIR are recursively expanded variables which were\ninitialized to $(shell pwd) and $(shell readlink -f ...) respectively.\nThose shell commands would run each and every time these variables were\nexpanded, which occurs many times: for example, open build/reliance.mk\nand observe how many P_BASEDIR references there are.  Running \"make\"\nfrom projects/linux would spawn 2547 processes, resulting in a long and\nunnecessary delay.\n\nFix this problem by initializing P_PROJDIR and P_BASEDIR using relative\npaths, eliminating the $(shell ...) commands.\n\nSome sample builds of projects/linux, before and after this change:\n\n    $ make clean && time make\n    before => 7.381 sec\n    after  => 1.912 sec (74.096% reduction)\n\n    $ make && time make\n    before => 4.331 sec\n    after  => 0.006 sec (99.861% reduction)\n\nShout out to Jeremy Sherrill (@jeremysherrill) for his help in\ninvestigating this issue.","shortMessageHtmlLink":"linux: use relative directory paths in Makefile"}},{"before":"01b99319a9ebed50c7adc56aced0b1c0a83b8868","after":"8a1d178dd4633b364e367ecda2b569cf2fea9ca5","ref":"refs/heads/master","pushedAt":"2024-01-17T01:15:13.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"Change a few URLs from http to https","shortMessageHtmlLink":"Change a few URLs from http to https"}},{"before":"0bd5e6297badd784e0fd18dcaa8c0fd58ac9c0bf","after":"01b99319a9ebed50c7adc56aced0b1c0a83b8868","ref":"refs/heads/master","pushedAt":"2024-01-17T00:39:18.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"Use an Internet Archive link for hackersdelight.org\n\nhackersdelight.org was formerly the web site for the \"Hacker's Delight\"\nbook.  The domain name seems to have changed ownership and is now\nused for something different.  Don't link to that unrelated web site;\ninstead, link to final Internet Archive snapshot for the original web\nsite.","shortMessageHtmlLink":"Use an Internet Archive link for hackersdelight.org"}},{"before":"42ab64a7c35b654f21d22e32d6b78b90abfd4219","after":"0bd5e6297badd784e0fd18dcaa8c0fd58ac9c0bf","ref":"refs/heads/master","pushedAt":"2024-01-16T00:41:50.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"core: name lookups don't need read permissions\n\nSearch (aka execute) permission is all that should be required to\nlook up a name in a directory.  Read permission isn't necessary.\nThis conclusion is supported both by a close reading of the POSIX\nspecification and by empirical tests of POSIX-like implementations.","shortMessageHtmlLink":"core: name lookups don't need read permissions"}},{"before":"42c781f483e9b2c90c2496d55f844fb70b0aefad","after":"42ab64a7c35b654f21d22e32d6b78b90abfd4219","ref":"refs/heads/master","pushedAt":"2024-01-02T19:45:59.000Z","pushType":"push","commitsCount":2,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"Add an EditorConfig file\n\nSee <https://editorconfig.org/> for an explanation of what this is.","shortMessageHtmlLink":"Add an EditorConfig file"}},{"before":"fd7b2528bde889844e761effc13ccb7a50f7b168","after":"42c781f483e9b2c90c2496d55f844fb70b0aefad","ref":"refs/heads/master","pushedAt":"2023-07-25T17:18:48.000Z","pushType":"pr_merge","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"Initialized ret to 0 in DiskGetGeometry (#38)","shortMessageHtmlLink":"Initialized ret to 0 in DiskGetGeometry (<a class=\"issue-link js-issue-link\" data-error-text=\"Failed to load title\" data-id=\"1819648710\" data-permission-text=\"Title is private\" data-url=\"https://github.com/tuxera/reliance-edge/issues/38\" data-hovercard-type=\"pull_request\" data-hovercard-url=\"/tuxera/reliance-edge/pull/38/hovercard\" href=\"https://github.com/tuxera/reliance-edge/pull/38\">#38</a>)"}},{"before":"5cc9a95cd34d337435f775c827a77b6437f25c1b","after":"fd7b2528bde889844e761effc13ccb7a50f7b168","ref":"refs/heads/master","pushedAt":"2023-06-15T21:54:44.619Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"imgbld: fix compile when settable attrs disabled\n\nIbCopyAttr() only exists when HAVE_SETTABLE_ATTR is true.  However,\nIbCopyFile() was calling it unconditionally, leading to a compilation\nerror in configurations where HAVE_SETTABLE_ATTR was false.\n\nSpecifically, this fixes a compilation error for configurations which\nhave the following in redconf.h:\n\n  #define REDCONF_API_POSIX 1\n  #define REDCONF_POSIX_OWNER_PERM 0\n  #define REDCONF_INODE_TIMESTAMPS 0","shortMessageHtmlLink":"imgbld: fix compile when settable attrs disabled"}},{"before":"e7f26e7c9b2cf9a3940c80c4d2584f80adb2c59d","after":"5cc9a95cd34d337435f775c827a77b6437f25c1b","ref":"refs/heads/master","pushedAt":"2023-04-10T23:51:34.000Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"imgbld: update stale comment about permissions\n\nThe comment \"if the POSIX-like API ever begins to enforce permissions\"\nimplies that the POSIX-like API does not enforce permissions.  At the\ntime that comment was written, permissions had only been partially\nimplemented: they were stored but not enforced.  In the finished\nimplementation that we have today, permissions are enforced (if they\nare enabled in the configuration).","shortMessageHtmlLink":"imgbld: update stale comment about permissions"}},{"before":"250f06f3d6cec8c0ff1de923b815bdbf9ebffde3","after":"e7f26e7c9b2cf9a3940c80c4d2584f80adb2c59d","ref":"refs/heads/master","pushedAt":"2023-03-08T21:16:29.673Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"posix: remove R_OK from InodeMustBeSearchableDir()\n\nChecking for read permissions (via R_OK) in InodeMustBeSearchableDir()\nis either redundant or incorrect.  Remove it.\n\nAssume dirfd is a file descriptor for a directory whose permission bits\nare 0111 (i.e., search permissions only).  Consider the following API\ncalls:\n\n1. red_openat(dirfd, \"..\", RED_O_RDONLY)\n2. red_openat(dirfd, \"./..\", RED_O_RDONLY)\n3. red_openat(dirfd, \".\", RED_O_RDONLY)\n\nBoth #1 and #2 should succeed (assuming dirfd's parent directory has\nread permissions).  However, InodeMustBeSearchableDir() would cause\nboth #1 and #2 to fail, since it will check whether dirfd has read\npermissions, even though those aren't required.\n\nCase #3 should fail, and does fail, but InodeMustBeSearchableDir() does\nnot need to be the place where this failure originates, because the\ncheck for read permissions will occur later, in FildesOpen().  The R_OK\ncheck in InodeMustBeSearchableDir() is redundant.\n\nSee also commit 80c2c79bec, the origin of the relevant code.","shortMessageHtmlLink":"posix: remove R_OK from InodeMustBeSearchableDir()"}},{"before":"80c2c79bec25e8fe4d9ada219f75b7bbdc01df2e","after":"250f06f3d6cec8c0ff1de923b815bdbf9ebffde3","ref":"refs/heads/master","pushedAt":"2023-03-08T01:25:17.766Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"posix: fix InodeMustBeSearchableDir() for root dir\n\nWhen permissions are enabled, InodeMustBeSearchableDir() cannot be\noptimized to \"do nothing and return success\" for the root directory,\nbecause it is still necessary to check whether the root directory is\nsearchable.\n\nFixes an oversight in commit 80c2c79bec.","shortMessageHtmlLink":"posix: fix InodeMustBeSearchableDir() for root dir"}},{"before":"76dd6be8238fe68a107a2d7bc01e32df5af1bc9b","after":"80c2c79bec25e8fe4d9ada219f75b7bbdc01df2e","ref":"refs/heads/master","pushedAt":"2023-03-08T00:13:31.485Z","pushType":"push","commitsCount":1,"pusher":{"login":"danielrlewis","name":"Daniel R. lewis","path":"/danielrlewis","primaryAvatarUrl":"https://avatars.githubusercontent.com/u/12091751?s=80&v=4"},"commit":{"message":"posix: fix search permission check for . and ..\n\nIf permissions are enabled, a \".\" or \"..\" path element should provoke\nan EACCES error if the parent directory is non-searchable.\n\nFor normal names, PathWalkFollow() will call into RedCoreLookup(),\nwhich will check whether the parent directory is searchable and return\nan EACCES error if it's not.  However, PathWalkFollow() treats \".\" and\n\"..\"  as special cases, and the directory permissions were not being\nchecked on those code paths.  As a result, all path-based APIs which\nonly entered into a non-searchable directory via \".\" or \"..\" could\nerroneously return success rather than the required EACCES error.\n\nInodeMustBeDir() was already used to check whether the inode for the\npath component prior to \".\" or \"..\" was a directory.  Modify and rename\nthat function so that it checks whether the inode is a searchable\ndirectory, thereby fixing this issue.","shortMessageHtmlLink":"posix: fix search permission check for . and .."}}],"hasNextPage":false,"hasPreviousPage":false,"activityType":"all","actor":null,"timePeriod":"all","sort":"DESC","perPage":30,"cursor":"djE6ks8AAAAD6lZ0fwA","startCursor":null,"endCursor":null}},"title":"Activity · tuxera/reliance-edge"}