Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split out the "fix" functionality of prisma format #24227

Open
7 tasks
Druue opened this issue May 17, 2024 · 0 comments
Open
7 tasks

Split out the "fix" functionality of prisma format #24227

Druue opened this issue May 17, 2024 · 0 comments
Labels
kind/tech A technical change. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: breaking change topic: cli topic: prisma format CLI: prisma format topic: prisma validate --fix (Command does not exist yet, but if it did, this functionality would be triggered by it)

Comments

@Druue
Copy link
Contributor

Druue commented May 17, 2024

Context

The relevant code that adds the ""fix"" functionality to format is in:

Which takes input from the three following functions:

Instead of automatically being applied through format, we should offer the separate ability to fix the issues this catches. We have diagnostics for two of these already (they aren't used, however, in the current implementation of fixes in format)

image

As this is a breaking change, we should look at the following intermediary changes first

Temporary

Tasks

Nice-to-have

Related Notion Page

@Druue Druue added topic: cli tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: prisma format CLI: prisma format kind/tech A technical change. labels May 17, 2024
@janpio janpio changed the title Split out the fix functionality of prisma format Split out the "fix" functionality of prisma format May 17, 2024
@jkomyno jkomyno added the team/schema Issue for team Schema. label May 17, 2024
@janpio janpio added topic: breaking change topic: prisma validate --fix (Command does not exist yet, but if it did, this functionality would be triggered by it) labels May 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/tech A technical change. team/schema Issue for team Schema. tech/engines Issue for tech Engines. tech/typescript Issue for tech TypeScript. topic: breaking change topic: cli topic: prisma format CLI: prisma format topic: prisma validate --fix (Command does not exist yet, but if it did, this functionality would be triggered by it)
Projects
None yet
Development

No branches or pull requests

3 participants