Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Basic implementation of HELLO #398

Merged
merged 18 commits into from
May 20, 2024
Merged

Basic implementation of HELLO #398

merged 18 commits into from
May 20, 2024

Conversation

badrishc
Copy link
Contributor

@badrishc badrishc commented May 18, 2024 •
edited

Towards #387
Fixes #346
Fixes #179

@badrishc badrishc mentioned this pull request May 18, 2024
Merged
2 tasks
TalZaccai
TalZaccai requested changes May 18, 2024
View reviewed changes
libs/server/Resp/AdminCommands.cs Show resolved Hide resolved
libs/server/Resp/AdminCommands.cs Show resolved Hide resolved
libs/server/Resp/AdminCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/AdminCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/AdminCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/AdminCommands.cs Outdated Show resolved Hide resolved
libs/server/Resp/AdminCommands.cs Show resolved Hide resolved
libs/server/Resp/AdminCommands.cs Outdated Show resolved Hide resolved
@badrishc
Copy link
Contributor Author

Made this PR have HELLO work only with RESP2, the other open PR will add RESP3 for async.

@badrishc
Copy link
Contributor Author

fixed warnings

TalZaccai
TalZaccai requested changes May 20, 2024
View reviewed changes
Copy link
Contributor

@TalZaccai TalZaccai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, added a couple of questions / comments

@TalZaccai TalZaccai merged commit 5a65fd7 into main May 20, 2024
23 checks passed
@TalZaccai TalZaccai deleted the badrishc/hello branch May 20, 2024 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yrajas yrajas yrajas left review comments

@TalZaccai TalZaccai TalZaccai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

API Coverage - Implement HELLO Incorrect PONG issued on subscriber channel
3 participants
@badrishc @TalZaccai @yrajas