query table partition data table alias issue

[travelliu]

Description

SELECT x.* FROM public.newtable_1 PARTITION(part_1) x --> correct

SELECT x.* FROM public.newtable_1 x PARTITION(part_1) error

so

https://github.com/dbeaver/dbeaver/blob/107958e9d1f3e1b181c554d472a16c20cb1dc6e3/plugins/org.jkiss.dbeaver.model.jdbc/src/org/jkiss/dbeaver/model/impl/jdbc/struct/JDBCTable.java#L157C1-L166C78

        StringBuilder query = new StringBuilder(100);
        query.append("SELECT ");
        appendSelectSource(monitor, query, tableAlias, rowIdAttribute);
        query.append(" FROM ").append(getTableName());
        if (tableAlias != null) {
            query.append(" ").append(tableAlias); //$NON-NLS-1$
        }
        appendExtraSelectParameters(query);
        SQLUtils.appendQueryConditions(dataSource, query, tableAlias, dataFilter);
        SQLUtils.appendQueryOrder(dataSource, query, tableAlias, dataFilter);

need change to

        appendExtraSelectParameters(query);
     if (tableAlias != null) {
            query.append(" ").append(tableAlias); //$NON-NLS-1$
        }

DBeaver Version

23.3.0

Operating System

No response

Database and driver

No response

Steps to reproduce

No response

Additional context

No response

[LonwoLonwo]

Hello @travelliu

Sorry, what you are doing is not clear.
Please provide clear steps to reproduce your issue.

[E1izabeth]

@travelliu could you share the way to reproduce the issue?

[travelliu]

@travelliu could you share the way to reproduce the issue?

No. I just see that the SQL statement generated by this code is not logically correct.
Oracle aliases should be after the partition name.

appendExtraSelectParameters Functions now seem to just add partition syntax

[E1izabeth]

@hallstorm it's not connected to this issue

[E1izabeth]

We don't add aliases when building select from partition

dbeaver/plugins/org.jkiss.dbeaver.ext.oracle/src/org/jkiss/dbeaver/ext/oracle/model/OracleTablePartition.java

Lines 257 to 263 in 107958e

	protected boolean needAliasInSelect(
	@Nullable DBDDataFilter dataFilter,
	@Nullable DBDPseudoAttribute rowIdAttribute,
	@NotNull DBPDataSource dataSource
	) {
	return false;
	}