-
Notifications
You must be signed in to change notification settings - Fork 546
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support GROUP BY ALL
#15946
Comments
Referencing the columns by ordinal is an alternative - although a bit less convenient: SELECT
col1,
agg(col2),
col3
FROM t01;
GROUP BY
1, 3; |
This comment was marked as resolved.
This comment was marked as resolved.
Hi, Can i Work on this feature |
@DHRUV6029 Thx for volunteering to work on this! |
Hello , Thanks for assigning me the task. Thanks |
@DHRUV6029 Just GROUP BY ALL. Ordinal number references are already implemented. |
Hi can you guys help me with files where code for group by is already implemented ? |
You'll have to extend the parser grammar to allow for
This then implies that the
Could model this via a The crate/server/src/main/java/io/crate/analyze/relations/RelationAnalyzer.java Lines 415 to 419 in 1e92620
|
Thanks , Will submit a PR by this weekend |
Problem Statement
When interactively writing queries in CrateDB one needs to specify the list of columns in two locations for aggregations, which can lead to broken queries and pontential bugs.
Possible Solutions
To prevent broken queries and pontential bugs by keeping the SELECT granularity aligned to the GROUP BY granularity one could either add support for
GROUP BY ALL
similiar to Snowflake, DuckDB, ClickHouse and othersALL
is already a reserved keyword - this wouldn't be a breaking change.Considered Alternatives
No response
The text was updated successfully, but these errors were encountered: