-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BugFix] multiple sys_log_to_console=true entry in fe.conf every time… #45851
base: main
Are you sure you want to change the base?
Conversation
… fe is started with --logconsole option Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
… fe is started with --logconsole option Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
… fe is started with --logconsole option Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
[FE Incremental Coverage Report]✅ pass : 1 / 1 (100.00%) file detail
|
… fe is started with --logconsole option Signed-off-by: Rohit Satardekar <rohitrs1983@gmail.com>
Quality Gate passedIssues Measures |
[BE Incremental Coverage Report]✅ pass : 0 / 0 (0%) |
@@ -96,7 +96,7 @@ public class Config extends ConfigBase { | |||
* Log to file by default. set to `true` if you want to log to console | |||
*/ | |||
@ConfField | |||
public static boolean sys_log_to_console = false; | |||
public static boolean sys_log_to_console = System.getenv("SYS_LOG_TO_CONSOLE").trim().equals("1"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like it doesn't work for this way to init the sys_log_to_console
, need to take a look how to make it work or find an alternative way to do it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
System.getenv("SYS_LOG_TO_CONSOLE")
can be null
if the env is not set.
Why I'm doing:
multiple sys_log_to_console=true entry in fe.conf every time fe is started with --logconsole option
What I'm doing:
fe.conf should have only single entry sys_log_to_console=true
Fixes #45850
What type of PR is this:
Does this PR entail a change in behavior?
If yes, please specify the type of change:
Checklist:
Bugfix cherry-pick branch check: