Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use java.nio for all file operations #17

Open
nterry opened this issue Mar 22, 2019 · 2 comments
Open

Use java.nio for all file operations #17

nterry opened this issue Mar 22, 2019 · 2 comments
Assignees

Comments

@nterry
Copy link

nterry commented Mar 22, 2019

This would allow for alternate Filesystem implementations to be used such as JimFS and such for unit tests.

@FarooqKhan
Copy link
Collaborator

I had not realised this, I will try to check this out and fix it when i get some time.

@nterry
Copy link
Author

nterry commented Apr 15, 2019

@FarooqKhan Yeah man, check out JimFS here: https://github.com/google/jimfs

It would allow users such as myself to unit test without having to mock. You could have a constructor accept a java.nio.FileSystem object and default to the default filesystem.

@FarooqKhan FarooqKhan self-assigned this Jun 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants